Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifests: include kubernetes.yaml #1474

Closed
wants to merge 1 commit into from
Closed

manifests: include kubernetes.yaml #1474

wants to merge 1 commit into from

Conversation

jbtrystram
Copy link
Contributor

FCOS had shipped ZRAM-generator for a while but it was not shared with RHCOS. Moved the package to a different sub-manifest that would regroup kubernetes-specific things.
The swap on ZRAM would still need to be actually enabled through a config file [1] but that should be done by the MCO.

[1] https://github.com/systemd/zram-generator/blob/main/man/zram-generator.conf.md

ref: coreos/fedora-coreos-config#2937
ref: https://issues.redhat.com/browse/COS-2507

@jbtrystram
manifests: include kubernetes.yaml
9c01152 
FCOS had shipped ZRAM-generator for a while but it was not shared
with RHCOS. Moved the package to a different sub-manifest that
would regroup kubernetes-specific things.
The swap on ZRAM would still need to be actually enabled through
a config file [1] but that should be done by the MCO.

[1] https://github.com/systemd/zram-generator/blob/main/man/zram-generator.conf.md

ref: coreos/fedora-coreos-config#2937
ref: https://issues.redhat.com/browse/COS-2507
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jbtrystram
Copy link
Contributor Author

/hold

@jbtrystram jbtrystram marked this pull request as draft April 3, 2024 14:29
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@jbtrystram: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-9-build-test-metal 9c01152 link true /test rhcos-9-build-test-metal
ci/prow/images 9c01152 link true /test images
ci/prow/scos-9-build-test-metal 9c01152 link true /test scos-9-build-test-metal
ci/prow/rhcos-9-build-test-qemu 9c01152 link true /test rhcos-9-build-test-qemu
ci/prow/scos-9-build-test-qemu 9c01152 link true /test scos-9-build-test-qemu
ci/prow/validate 9c01152 link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot requested review from cgwalters and prestist April 3, 2024 14:30
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@dustymabe
Copy link
Member

I'm thinking there is a better way: coreos/fedora-coreos-config#2937 (comment)

@jbtrystram jbtrystram closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@prestist prestist Awaiting requested review from prestist

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbtrystram @openshift-merge-robot @dustymabe